Question: Unexpected colours on custom theme

[cjlotz]

Hello. I've been updating our code with the changes introduced by #4062 . I'm using the following code to set a custom theme

  private static void RunApplication(IHost host)
  {
      Application.Init();
      ConfigurationManager.Enable(ConfigLocations.All);
      ThemeManager.Theme = ThemeManager.GetThemeNames().FirstOrDefault(x => x == "Anders") ?? "Default";

All seems fine except for my listview and also all dialogs not showing up in the expected theme colours if I compare that against the UICatalog samples. I'm not setting any color related properties on these controls. Any pointers as to what I might be missing here? I'm using latest alpha release

[tig]

Looking at this now.

What happens if you call CM.Enable BEFORE Application.Init?

[cjlotz]

Only the Default theme is then available

[tig]

I'm confused.

ConfigurationManager.Enable(ConfigLocations.All); should be called before you call Application.Init, so i assumed that was your issue.

Can you share more of your code? Where are you setting the breakpoint for the above screenshot?

[cjlotz]

Sorry for the confusion. Hope this clarifies?

[tig]

HardCoded only has one theme.

Use All.

[cjlotz]

Sorry about that. Original issue still persists once I fixed that

[tig]

Please show the code you're using to display the Dialog and create the ListView.

I'm struggling to reproduce this issue...

[tig]

Also, what happens if you put the ThemeManager.Theme = statement before Application.Init (but after CM.Enable)?

[cjlotz]

Hello. Setting the theme before Application.Init has no effect. Here is the snippet for showing the main view at startup. LicenceGeneratorView inherits directly from Toplevel.

    private static void RunApplication(IHost host)
    {
        ConfigurationManager.Enable(ConfigLocations.All);
        ThemeManager.Theme = ThemeManager.GetThemeNames().FirstOrDefault(x => x == "Anders") ?? "Default";
        
        Application.Init();
            
        var loggerFactory = host.Services.GetService<ILoggerFactory>();
        Logger = loggerFactory.CreateLogger("Startup");
            
        var registry = host.Services.GetService<ILicenceRegistry>();
        var gateway = new OnKeyApiGateway(host.Services.GetService<IHttpClientFactory>(), loggerFactory);

        SetApplicationPaths();

        MetadataSingleton.LicenceRegistry = registry;
        var main = new LicenceGeneratorView(registry, gateway, Settings, loggerFactory);
            
        Application.Run(main, ex =>
        {
            HandleException(ex);
            return false;
        });

        Application.Shutdown();
    }

Here is the code for showing the dialog from within LicenceGeneratorView:

    public void ConnectToOnKey()
    {
        var dialog = new SelectOnKeyServerDialog(Servers);
        Application.Run(dialog);

        if (dialog.Accepted)
        {
            Server = dialog.SelectedServer;
            ConnectToOnKeyServer(Server);
        }
    }

with the SelectOnKeyServerDialog class defined as

using System.Collections.Generic;
using System.Collections.ObjectModel;
using Terminal.Gui.App;
using Terminal.Gui.Input;
using Terminal.Gui.ViewBase;
using Terminal.Gui.Views;

namespace Pragma.OnKey.LicenceGenerator;

public class SelectOnKeyServerDialog : Dialog
{
    private readonly ObservableCollection<OnKeyServer> _items;

    public SelectOnKeyServerDialog(ObservableCollection<OnKeyServer> items)
    {
        _items = items;
        InitialiseViews();
    }

    #region Properties

    public bool Accepted { get; private set; }
    public OnKeyServer SelectedServer { get; private set; }
    private Label LabelItems { get; set; }
    private Label LabelClientSecret { get; set; }
    private TextField TextClientSecret { get; set; }
    private Label LabelHint { get; set; }
    private ComboBox ComboBoxItems { get; set; }

    #endregion

    #region Methods

    private void InitialiseViews()
    {
        var ok = new Button { Text = "_Ok", IsDefault = true };
        ok.Accepting += (_, _) =>
        {
            if (SelectedServer != null && !string.IsNullOrEmpty(TextClientSecret.Text))
            {
                Accepted = true;
                SelectedServer.ClientSecret = TextClientSecret.Text;
                Application.RequestStop();
            }
            else
            {
                ViewHelper.ShowError(50, 10, "\nPlease enter all values");
            }
        };
            
        var cancel = new Button { Text = "_Cancel" };
        cancel.Accepting += (_, _) =>
        {
            Accepted = false;
            Application.RequestStop();
        };

        Title = "Select On Key Server";
        Height = 15;
        Width = Dim.Percent(50);

        LabelHint = new Label { Text = "Press Alt+Down to expand Servers", X = 0, Y = 1, CanFocus = false };
        LabelItems = new Label { Text = "Servers", X = 0, Y = Pos.Bottom(LabelHint)+1, CanFocus = false };
        LabelClientSecret = new Label { Text = "Client Secret", X = 0, Y = Pos.Bottom(LabelItems)+1, CanFocus = false };
        TextClientSecret = new TextField { X = Pos.Right(LabelClientSecret)+1, Y = Pos.Bottom(LabelItems)+1, Width = Dim.Fill(), Secret = true };
            
        ComboBoxItems = new ComboBox { X = Pos.Left(TextClientSecret), Y = Pos.Bottom(LabelHint)+1, Width = Dim.Fill(), Height = 5 };
        ComboBoxItems.SetSource(new ObservableCollection<OnKeyServer>(_items));
        ComboBoxItems.SelectedItemChanged += ComboBoxItemsOnSelectedItemChanged;
        ComboBoxItems.KeyBindings.Replace(Key.F4, Key.CursorDown.WithAlt);
            
        var views = new List<View> { LabelItems, ComboBoxItems, LabelClientSecret, TextClientSecret, LabelHint };

        Add(views.ToArray());
        AddButton(ok);
        AddButton(cancel);
    }

    private void ComboBoxItemsOnSelectedItemChanged(object sender, ListViewItemEventArgs e)
    {
        SelectedServer = e.Item >= 0 ? _items[ComboBoxItems.SelectedItem] : default;
        TextClientSecret.Text = SelectedServer?.ClientSecret ?? string.Empty;
    }

    #endregion
}

Let me know if you require any more context. Thanks!

[tig]

I modified SelfContained/Program.cs thusly, and can't reproduce this:

// This is a test application for a self-contained single file.

using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using Terminal.Gui.Configuration;
using Terminal.Gui.App;
using Terminal.Gui.ViewBase;
using Terminal.Gui.Views;

namespace SelfContained;

public static class Program
{
    [RequiresUnreferencedCode ("Calls Terminal.Gui.Application.Run<T>(Func<Exception, Boolean>, IConsoleDriver)")]
    private static void Main (string [] args)
    {
        ConfigurationManager.Enable (ConfigLocations.All);
        ThemeManager.Theme = ThemeManager.GetThemeNames ().FirstOrDefault (x => x == "Anders") ?? "Default";
        Application.Init ();

        ExampleWindow app = new ();
        Application.Run (app);

        // Dispose the app object before shutdown
        app.Dispose ();

        // Before the application exits, reset Terminal.Gui for clean shutdown
        Application.Shutdown ();

        // To see this output on the screen it must be done after shutdown,
        // which restores the previous screen.
        Console.WriteLine ($@"Username: {ExampleWindow.UserName}");
    }
}

// Defines a top-level window with border and title
public class ExampleWindow : Window
{
    public static string? UserName;

    public ExampleWindow ()
    {
        Title = $"Example App ({Application.QuitKey} to quit)";

        // Create input components and labels
        var usernameLabel = new Label { Text = "Username:" };

        var userNameText = new TextField
        {
            // Position text field adjacent to the label
            X = Pos.Right (usernameLabel) + 1,

            // Fill remaining horizontal space
            Width = Dim.Fill ()
        };

        var passwordLabel = new Label
        {
            Text = "Password:", X = Pos.Left (usernameLabel), Y = Pos.Bottom (usernameLabel) + 1
        };

        var passwordText = new TextField
        {
            Secret = true,

            // align with the text box above
            X = Pos.Left (userNameText),
            Y = Pos.Top (passwordLabel),
            Width = Dim.Fill ()
        };

        // Create login button
        var btnLogin = new Button
        {
            Text = "Login",
            Y = Pos.Bottom (passwordLabel) + 1,

            // center the login button horizontally
            X = Pos.Center (),
            IsDefault = true
        };

        // When login button is clicked display a message popup
        btnLogin.Accepting += (s, e) =>
                              {
                                  if (userNameText.Text == "admin" && passwordText.Text == "password")
                                  {
                                      MessageBox.Query ("Logging In", "Login Successful", "Ok");
                                      UserName = userNameText.Text;
                                      Application.RequestStop ();
                                  }
                                  else
                                  {
                                      MessageBox.ErrorQuery ("Logging In", "Incorrect username or password", "Ok");
                                  }

                                  // When Accepting is handled, set e.Handled to true to prevent further processing.
                                  e.Handled = true;
                              };

        // Add the views to the Window
        Add (usernameLabel, userNameText, passwordLabel, passwordText, btnLogin);

        ListView lv = new ListView ()
        {
            Y = Pos.AnchorEnd (),
            Height = Dim.Auto (),
            Width = Dim.Auto (),
            Source = new ListWrapper<string> (["One", "Two", "Three"])

        };

        Add (lv);

    }
}

When run, I see:

Which is correct behavior.

What's your environment? What happens if you run the above sample the same way you're running your app?

[cjlotz]

Thanks for sticking with me. Your example works fine on my machine as well. I did some further investigation and the only difference was the version used. I used an older version - 2.0.0-alpha.3721. After I updated it to the latest 2.0.0-alpha.3775 , things started to work correctly. So it seems issue was resolved somewhere in between these two versions.