-
Notifications
You must be signed in to change notification settings - Fork 724
Description
Mini-Spec
Three scenarios so far:
- User clicks on a button in the Border (top/right) that causes a Modal to quit.
- User clicks on a button in the Border (top/right) that causes an Overlapped to close/hide.
- User clicks on a button in the Border (top/right) that causes the view to collapse/expand.
We will create 3 new View subclasses, one for each of these:
ApplicationQuitter
- Glyph is an X.MouseClick
, andKeyBinding (Space)
invokeCommand.QuitToplevel
(to be renamed toCommand.Close
). The command handler simply callsApplication.RequestStop()
.ViewHider
- Glyph is an X.MouseClick
, andKeyBinding (Space)
invokeCommand.Close
. The command handler simply callsSuperView.Parent.Visible = false
. (or perhaps we addClose()
as a verb on View?).ViewExpander
- Glyph is a up/down arrow.MouseClick
, andKeyBinding (Space)
invokeCommand.ToggleExpandCollapse
. Command hander- Disables/Hides/Enables/Shows
SuperView.Parent
's subviews - Sets the Height of the
SuperView.Parent
to 3 orDim.Auto
- Disables/Hides/Enables/Shows
Devs will add these views via view.Border.Add
.
This is what ViewExpander
will look like/do:
I've built a POC of ViewExpander
in #3376
Background
This is a sub-issue of:
Will be fixed in this PR as a proof:
Background
Is your feature request related to a problem? Please describe.
I want user to be able to close button by [X] button near dialog title from top right side. And I want them to be shown in Query dialogs by default. Because when you pass no button its not clear, that you need Escape button to be pressed to close it.
Describe the solution you'd like
For dialogs and querries to have [x] button: Dialog Title [x]
Describe alternatives you've considered
Have close button as now.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status