Skip to content

Conversation

@domesticmouse
Copy link
Contributor

Note, this change appears to have broken the back button in the titlebar. I'm guessing there was an incorrect non-null field somewhere that I cleaned up.

Tests would really help =)

@esDotDev
Copy link
Contributor

Wow, thanks for all the work! Might take us a bit to land this, but we'll make sure it gets in.

@domesticmouse domesticmouse changed the title Adopt flutter_lints 1.0 Adopt pkg:flutter_lints 1.0 Jul 9, 2021
@esDotDev
Copy link
Contributor

esDotDev commented Aug 11, 2021

It seems the back button issue is due to the TitleBar not rebuilding when selectedBook is changed, not really sure why it worked before...

To fix, change line 36 of app_title_bar.dart to:
bool canGoBack = context.select((BooksModel m) => m.currentBook != null);

And then I would remove appModel.canPopNav as it's not used anywhere else.

Can you make those tweaks, and then I can land this?

EDIT- Nevermind, I was able to push those fixes to your repo :)

@esDotDev esDotDev merged commit 8f42684 into gskinnerTeam:master Aug 11, 2021
@domesticmouse domesticmouse deleted the flutter-lints branch August 12, 2021 22:03
@domesticmouse
Copy link
Contributor Author

Thanks!

@ingmferrer ingmferrer mentioned this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants