Skip to content

feat: allow passing a focus node #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow passing a focus node #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions lib/focusable_control_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class FocusableControlBuilder extends StatefulWidget {
this.autoFocus = false,
this.descendantsAreFocusable = true,
this.descendantsAreTraversable = true,
this.focusNode,
}) : super(key: key);

/// Return a widget representing the control based on the current [FocusableControlState]
Expand Down Expand Up @@ -68,6 +69,9 @@ class FocusableControlBuilder extends StatefulWidget {
/// Passed along to the [FocusableActionDetector]
final bool descendantsAreTraversable;

/// Optional. Passed along to the [FocusableActionDetector]. Otherwise, an internally managed [FocusNode] will be used.
final FocusNode? focusNode;

@override
State<FocusableControlBuilder> createState() => FocusableControlState();
}
Expand All @@ -76,7 +80,7 @@ class FocusableControlBuilder extends StatefulWidget {
/// This is passed to the builder function, and can be used to determine the current state of the control.
class FocusableControlState extends State<FocusableControlBuilder> {
final FocusNode _focusNode = FocusNode();
FocusNode get focusNode => _focusNode;
FocusNode get focusNode => widget.focusNode ?? _focusNode;

bool _isHovered = false;
bool get isHovered => _isHovered;
Expand Down Expand Up @@ -113,7 +117,7 @@ class FocusableControlState extends State<FocusableControlBuilder> {

void _handlePressed() {
if (widget.requestFocusOnPress) {
_focusNode.requestFocus();
focusNode.requestFocus();
}
widget.onPressed?.call();
}
Expand All @@ -138,7 +142,7 @@ class FocusableControlState extends State<FocusableControlBuilder> {
// Create the core FocusableActionDetector
Widget content = FocusableActionDetector(
enabled: widget.enabled,
focusNode: _focusNode,
focusNode: focusNode,
autofocus: widget.autoFocus,
descendantsAreFocusable: widget.descendantsAreFocusable,
descendantsAreTraversable: widget.descendantsAreTraversable,
Expand Down