Skip to content

Don't segfault on header replay #14199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2018
Merged

Don't segfault on header replay #14199

merged 1 commit into from
Jan 26, 2018

Conversation

@kpayson64
Copy link
Contributor

@kpayson64 kpayson64 commented Jan 26, 2018

Upmerge of #14191

@kpayson64 kpayson64 requested a review from mehrdada January 26, 2018 19:00
mehrdada
mehrdada approved these changes Jan 26, 2018
View reviewed changes
Copy link
Contributor

@mehrdada mehrdada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM upmerge from 1.8.x

@grpc-testing
Copy link

grpc-testing commented Jan 26, 2018 

****************************************************************

libgrpc.so

     VM SIZE                                                                                       FILE SIZE
 ++++++++++++++ GROWING                                                                         ++++++++++++++
  +0.0%     +16 [None]                                                                              +24  +0.0%
  +0.1%     +16 src/core/lib/surface/call.cc                                                        +16  +0.1%
      +6.8%     +16 publish_app_metadata(grpc_call*, grpc_metadata_batch*, int) [clone .isra.5]         +16  +6.8%

  +0.0%     +32 TOTAL                                                                               +40  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link

grpc-testing commented Jan 26, 2018 

[trickle] No significant performance differences

@grpc-testing
Copy link

grpc-testing commented Jan 26, 2018 

[microbenchmarks] No significant performance differences

@mehrdada mehrdada assigned kpayson64 and unassigned mehrdada Jan 26, 2018
@mehrdada
Copy link
Contributor

mehrdada commented Jan 26, 2018

Please merge as soon as you see fit

@kpayson64 kpayson64 merged commit 389883f into grpc:v1.9.x Jan 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mehrdada mehrdada mehrdada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kpayson64 kpayson64

Labels

priority/P0/RELEASE BLOCKER

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kpayson64 @grpc-testing @mehrdada