Marked objects as Sendable or explicitly not Sendable #8
Conversation
Package.swift
Outdated
| .enableUpcomingFeature("ExistentialAny"), | ||
| .enableUpcomingFeature("InternalImportsByDefault"), | ||
| .enableUpcomingFeature("MemberImportVisibility"), | ||
| .unsafeFlags(["-Xfrontend", "-require-explicit-sendable"]), |
There was a problem hiding this comment.
We can't unconditionally add this flag here; these flags are always enabled. This one should only be added for development.
There was a problem hiding this comment.
Forgot to remove it! Thanks for the reminder.
There was a problem hiding this comment.
We can still have it so we can enable it during development though - here's an example: https://github.com/apple/swift-nio-ssl/blob/main/Package.swift#L59-L73
There was a problem hiding this comment.
Okay, let me add this then.
There was a problem hiding this comment.
I don't think we need to add it back behind a flag. It was helpful when we were doing lots of strict concurrency work, but we're very unlikely to flip that flag back on now that the work has been done.
|
|
||
| @usableFromInline | ||
| struct AsyncIterator: AsyncIteratorProtocol { | ||
| struct AsyncIterator: AsyncIteratorProtocol, Sendable { |
There was a problem hiding this comment.
In general, iterators aren't Sendable
There was a problem hiding this comment.
Should I mark it as not Sendable even though it currently conforms to Sendable then?
There was a problem hiding this comment.
The fact it implicitly conforms to Sendable right now because its implementation ticks all the boxes doesn't mean it should be Sendable when you consider the semantics. In general, all iterators keep some internal state to know what the next item should be. If an iterator is shared between different tasks, then it becomes undeterministic which task gets which element, which isn't good.
Also, I left the comment on this iterator but this should be true for all other iterators marked as Sendable on this PR.
### What changes were proposed in this pull request? This PR aims to upgrade `grpc-swift-2` to 2.2.0. ### Why are the changes needed? To bring the latest improvements and bug fixes. - https://github.com/grpc/grpc-swift-2/releases/tag/2.2.0 - grpc/grpc-swift-2#23 - grpc/grpc-swift-2#8 - grpc/grpc-swift-2#16 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #261 from dongjoon-hyun/grpc-swift-2.2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
3 participants
Performed the necessary changes to enable compiler flag
-require-explicit-sendable.