Skip to content

Conversation

@apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Oct 26, 2022

This is a java analogue of C++ PR: grpc/grpc#29922

Similar Go changes in grpc/grpc-go#5743 and grpc/grpc-go#5745

@ejona86

@apolcyn apolcyn changed the title c2p resolver: if federation is enabled then use xdstp LDS names and dont fallback due on a bootstrap file c2p resolver: if federation is enabled then use xdstp LDS names and dont fallback due to a bootstrap file Oct 26, 2022
@apolcyn apolcyn changed the title c2p resolver: if federation is enabled then use xdstp LDS names and dont fallback due to a bootstrap file c2p resolver: use federation if enabled via env var Oct 27, 2022
@apolcyn apolcyn marked this pull request as ready for review October 27, 2022 20:47
@apolcyn
Copy link
Contributor Author

apolcyn commented Oct 27, 2022

thanks for the review @ejona86 , can you please merge if looks good?

@ejona86 ejona86 merged commit a97db60 into grpc:master Oct 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants