Skip to content

[xDS] A97 - JWT token file call creds #12242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Zgoda91
Copy link

@Zgoda91 Zgoda91 commented Jul 23, 2025

implementing gRFC A97 grpc/proposal#492

@Zgoda91 Zgoda91 force-pushed the A97_jwt_token_call_creds branch 4 times, most recently from a8f76b0 to c781460 Compare July 28, 2025 06:26
@Zgoda91 Zgoda91 marked this pull request as ready for review July 28, 2025 06:27
@Zgoda91
Copy link
Author

Zgoda91 commented Jul 28, 2025

@ejona86 Could you please review this PR when you get a chance? Thanks!

@ejona86 ejona86 self-requested a review August 6, 2025 21:11
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shape of what I saw looked good. I didn't pay attention to any of the tests yet. I need to look through the provider plumbing more. But wanted to send the comments I have.

@Zgoda91 Zgoda91 force-pushed the A97_jwt_token_call_creds branch from c781460 to 85495b0 Compare August 11, 2025 12:31
@Zgoda91 Zgoda91 force-pushed the A97_jwt_token_call_creds branch from 85495b0 to 9f97bb5 Compare August 11, 2025 12:36
@Zgoda91
Copy link
Author

Zgoda91 commented Aug 11, 2025

@ejona86 PR ready for second round

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants