xds/internal: remove Generic resource Decoder and add concrete functions #8652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8652 +/- ##
==========================================
+ Coverage 81.21% 82.94% +1.72%
==========================================
Files 416 416
Lines 41002 32240 -8762
==========================================
- Hits 33298 26740 -6558
+ Misses 6226 4110 -2116
+ Partials 1478 1390 -88
🚀 New features to boost your workflow:
|
easwars
added
Type: Internal Cleanup
easwars
reviewed
Oct 15, 2025
easwars
reviewed
Oct 16, 2025
dfawley
changed the title
| } | ||
|
|
||
| func (c *clientImpl) WatchResourceV2(typeURL, resourceName string, watcher xdsclient.ResourceWatcher) (cancel func()) { | ||
| func (c *clientImpl) WatchResource(typeURL, resourceName string, watcher xdsclient.ResourceWatcher) (cancel func()) { |
There was a problem hiding this comment.
I think it is safe to just remove this method all together since this just calls the XDSClient method with the same signature and XDSClient is embedded in clientImpl so the call to WatchResource should implicitly call the function on XDSClient. Let me know if it is not the case and I am missing something.
There was a problem hiding this comment.
You are right. This can be completely removed.
easwars
approved these changes
Oct 28, 2025
| } | ||
|
|
||
| func (c *clientImpl) WatchResourceV2(typeURL, resourceName string, watcher xdsclient.ResourceWatcher) (cancel func()) { | ||
| func (c *clientImpl) WatchResource(typeURL, resourceName string, watcher xdsclient.ResourceWatcher) (cancel func()) { |
There was a problem hiding this comment.
You are right. This can be completely removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #8381
RELEASE NOTES: None