test: record peers by hostname in xds client #3409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
approved these changes
Feb 28, 2020
| case r := <-watcher.c: | ||
| if r != nil { | ||
| watcher.rpcsByPeer[(*r).GetServerId()]++ | ||
| watcher.rpcsByPeer[(*r).GetHostname()]++ |
Contributor
There was a problem hiding this comment.
Will we need to handle server_id for other purposes?
Contributor
Author
There was a problem hiding this comment.
I will likely need to incorporate server_id when using this client for our internal (grpclbv2) tests; on GCP, using hostname is convenient since hostname=VM instance name. Will revisit once this framework is brought in for use with the internal-only tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more fix for this.
server_idis actually unused in OSS, the client's rpc service should report the distribution by server hostname instead.@menghanl