Skip to content

Improve comment in GrpcChannel for WinHttpHandler + OS validation #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Improve comment in GrpcChannel for WinHttpHandler + OS validation #2237

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42564e2
Improve comment in GrpcChannel for WinHttpHandler + OS validation
JamesNK Aug 9, 2023
c6bfa86
Update src/Grpc.Net.Client/GrpcChannel.cs
JamesNK Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Grpc.Net.Client/GrpcChannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,15 @@ internal GrpcChannel(Uri address, GrpcChannelOptions channelOptions) : base(addr
Log.AddressPathUnused(Logger, Address.OriginalString);
}

// Validate the Windows version can support WinHttpHandler.
// Grpc.Net.Client + .NET Framework + WinHttpHandler requires features in WinHTTP (shipped in Windows) to work correctly.
// This scenario is supported in these versions of Windows or later:
// -Windows Server 2022 has partial support.
// -Unary and server streaming methods are supported.
// -Client and bidi streaming methods aren't supported.
// -Windows 11 has full support.
//
// GrpcChannel validates the Windows version is WinServer2022 or later.
// Note that this doesn't block using unsupported methods (client and bidi streaming) on WinServer2022.
const int WinServer2022BuildVersion = 20348;
if (HttpHandlerType == HttpHandlerType.WinHttpHandler &&
OperatingSystem.IsWindows &&
Expand Down