Modification flush: use the same thread as for apply (bounded thread pool for large modifications) #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er the computations This requires to reorganize the code and the transactions the fully load the data, hence the changes in NetworkModificationRepository with the new intermediate methods. Add testInsertCompositeModifications for symmetry with other code paths duplicate/move/ in the switch/case of ModificationController ?action=...
klesaulnier
approved these changes
Sep 25, 2025
SlimaneAmar
approved these changes
Oct 2, 2025
|
|
||
| private NetworkModificationResult applyAndFlush(List<ModificationApplicationGroup> modificationInfosGroups, | ||
| NetworkStoreListener listener) { | ||
| List<ApplicationStatus> groupsApplicationStatuses = apply(modificationInfosGroups, listener); |
klesaulnier
approved these changes
Oct 10, 2025
jonenst
force-pushed
the
applysamethreadflush
branch
from
621c489 to
7d5828e
Compare
|
SlimaneAmar
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.