implement async convert #743
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thangqp
reviewed
Oct 17, 2025
| "reload": "Reload", | ||
| "export.message.started": "Export file started", | ||
| "export.message.succeeded": "Export file succeeded", | ||
| "export.header.failed": "export file failed" |
There was a problem hiding this comment.
Suggested change
| "export.header.failed": "export file failed" | |
| "export.header.failed": "Export case failed" |
thangqp
reviewed
Oct 17, 2025
Comment on lines
+205
to
+206
| "export.message.started": "Export file started", | ||
| "export.message.succeeded": "Export file succeeded", |
There was a problem hiding this comment.
Suggested change
| "export.message.started": "Export file started", | |
| "export.message.succeeded": "Export file succeeded", | |
| "export.message.started": "Export case started", | |
| "export.message.succeeded": "Export case succeeded", |
thangqp
reviewed
Oct 17, 2025
Comment on lines
+22
to
+24
| const eventData = JSON.parse(event.data); | ||
| if (eventData?.headers?.notificationType === 'caseExportSucceeded') { | ||
| const { caseUuid, userId, exportUuid, error } = eventData.headers; |
There was a problem hiding this comment.
we can not typing the notification as in study?
thangqp
reviewed
Oct 17, 2025
| abortController: AbortController | ||
| ) => | ||
| backendFetch( | ||
| backendFetchText( |
There was a problem hiding this comment.
exportUuid return as string but when download you send UUID.. it is better to use all as UUID.. (also typing Notification as in study)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.