Skip to content

Refactor location query handling for OpenWeatherMap with new LocationSpecifier enum #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor location query handling for OpenWeatherMap with new LocationSpecifier enum #2153

wants to merge 2 commits into from

Conversation

@abd0-omar
Copy link

  • Replaced the raw location_query String with new LocationSpecifier enum in OpenWeatherMap.
  • Simplified the logic for retrieving the location used in the Api query parameters.
  • Replaced raw URL strings with reqwest::Url. I can revert this if it reduces readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@abd0-omar