Correctly handling html character entities that follow a url #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2014 10:08
any html character entities following a url are now not being treated like part of the query string
gregjacobs
added a commit
that referenced
this pull request
Oct 5, 2014
Correctly handling html character entities that follow a url
Owner
|
Nicely done. That's been a long-standing issue. One quick tip on English though: |
Author
|
Oh jeez, that was definitely not intentional. My editor decided to remove single quotes from where I was editing. I'll fix that up tomorrow and push it in, unless you don't mind fixing it up yourself. |
Owner
|
Haha, no worries, already fixed :) Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the html
<p>Joe went to yahoo.com and google.com</p>Generated the following output
<p>Joe went to <a href="http://yahoo.com ">yahoo.com </a>;and <a href="http://google.com">google.com</a></p>This handles this case as well as properly handling & inside urls (as part of the query string)
Approach is to split the html into parts separated at html character entities and process those parts separately. & characters are handled separately in the UrlMatch code, which ideally should know if it's dealing with html or text, but currently doesn't.