Use spaces instead of whitespace at phoneRegex #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issues with multiple spaces, tabs, new lines etc. Old: http://rubular.com/r/9hbxQPKhsp New: http://rubular.com/r/oM9xZ8jw1m Includes a new test for this.
Contributor
Author
|
Edit; found https://github.com/gregjacobs/Autolinker.js#contributing |
Owner
|
Hey, thanks so much for this, and thanks for contributing! Great job with tests too 👍 |
gregjacobs
added a commit
that referenced
this pull request
Nov 8, 2015
Use spaces instead of whitespace at phoneRegex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues with multiple spaces, tabs, new lines etc.
\040matches space character only;\smatches everything, tabs and all that stuff.Old: http://rubular.com/r/9hbxQPKhsp
New: http://rubular.com/r/oM9xZ8jw1m
Includes a new test for this.
Regarding #95 (comment)