Skip to content

Conversation

@engelgabriel
Copy link
Contributor

Hi, we are trying to help the best JS lib we use and love to have their own official packedege suport for Meteor.com

Now many good libraries have their own official packages

https://atmospherejs.com/?q=official

This PR adds the necessary files to start the process.

MeteorCommunity/discussions#14

If you accept, I'll help you all the way.

@engelgabriel engelgabriel changed the title Helping to create the official package meteor Helping to create the official package fo Meteor.com Jun 15, 2015
@engelgabriel engelgabriel changed the title Helping to create the official package fo Meteor.com Helping to create the official package for Meteor.com Jun 15, 2015
@gregjacobs
Copy link
Owner

Hey @engelgabriel, so sorry for the late response! I didn't really know anything about Meteor until I started researching just now, but seems cool.

Is this PR def still needed / up to date though? The second link you provided seems to say that wrapper libraries that add Meteor support are automatically updated as of September 2015. I'm just wondering if Autolinker needs the official support for sure or not. If so, I'll def merge.

Just a quick question on your PR otherwise. Should helpers.js register the template with the name 'autolink' or 'autolinker'? Also, Autolinker doesn't have an outputMarkdown option (line 13 of helpers.js). Is something like that needed? I'd imagine not since markdown supports HTML, but just curious.

@engelgabriel
Copy link
Contributor Author

Please merge the PR and I'll help with the rest of the process. I believe it is still better to have the offical package than just a third party wrapper.

@gregjacobs
Copy link
Owner

kk, you got it! Enjoy :)

gregjacobs added a commit that referenced this pull request Oct 21, 2015
Create official package for Meteor.com
@gregjacobs gregjacobs merged commit ac01255 into gregjacobs:master Oct 21, 2015
@engelgabriel
Copy link
Contributor Author

Can you please create and account at https://www.meteor.com/ and send me? I'll add you as owner of the organization "autolinker".

@gregjacobs
Copy link
Owner

Hey, added account. username: gregjacobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants