Skip to content

Refactor dsl select #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 24, 2021
Merged

Refactor dsl select #261

merged 5 commits into from
Nov 24, 2021

Conversation

leszekhanusz
Copy link
Collaborator

Reorganize the DSL code to have a single select method, with different is_valid_field method in different classes.
uml
.

  • Now verifying when adding a field that it correspond to its parent
  • Disallow adding fields to fragments before we chose the fragment type

@leszekhanusz leszekhanusz merged commit 9951100 into graphql-python:master Nov 24, 2021
@leszekhanusz leszekhanusz deleted the refactor_dsl_select branch March 12, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leszekhanusz