Skip to content

Conversation

xenomachina
Copy link
Contributor

The type descriptions were previously inconsistent (eg: Long's was "Long
type", while Short's was "Short as Int"), and unhelpful to clients that
aren't familiar with Java's type system (eg: "Short" may have no meaning
to a JavaScript programmer, nor would "java.math.BigInteger")

This change attempts to make the descriptions more consistent and also
programming language agnostic.

The type descriptions were previously inconsistent (eg: Long's was "Long
type", while Short's was "Short as Int"), and unhelpful to clients that
aren't familiar with Java's type system (eg: "Short" may have no meaning
to a JavaScript programmer, nor would "java.math.BigInteger")

This change attempts to make the descriptions more consistent and also
programming language agnostic.
@bbakerman
Copy link
Member

Thanks for this

@bbakerman bbakerman merged commit 9df62b5 into graphql-java:master Jan 8, 2022
@xenomachina xenomachina deleted the primitive-type-descriptions branch January 14, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants