Add max depth parameter to breadth first search #27
Conversation
src/Search/BreadthFirst.php
Outdated
| // track depth | ||
| $nodesNextLevel = $children->count(); | ||
| if (--$nodesThisLevel === 0) { | ||
| if (++$currentDepth > $maxDepth) goto done; |
There was a problem hiding this comment.
Suggested alternative:
if (++$currentDepth > $maxDepth) {
break;
}There was a problem hiding this comment.
This will break to foreach($children...) and not done:.
If you're anti goto: even when it's appropriate, I suggest return new Vertices($visited) instead, though I see this as being less DRY.
There was a problem hiding this comment.
I'm not sure I follow, but the break would be within the do … while loop only? Either way, I'm not anti goto and don't think any of the suggested alternatives really make that much of a difference. The less code, the better; the more structured, the better. This line of code currently violates existing coding standards due to lack of braces (easy fix), while we're at it we could replace the goto and remove another line. Slightly off-topic, but DRY is not really about lines of code, but more about not making business decisions at different locations which doesn't really apply here.
|
Test cases added, goto removed, brace added for if statement. Ship it! |
🎉2 participants
No description provided.