feat: add tests #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move context Model into an object to avoid `this` problems - make `date` and `year` fields optional - add docs for the `date` query and the `Numbers_Trivia` type - remove references to internal IBM docs
|
@kbrandwijk This should be ready to go. You can test with: yarn add @gramps/data-source-numbers@beta
|
|
Close/reopen to trigger a Travis build. |
kbrandwijk
reviewed
Jan 15, 2018
| Numbers_Trivia: { | ||
| date: data => data.date || null, | ||
| year: data => data.year || null, | ||
| }, |
There was a problem hiding this comment.
Why did you add resolvers for the optional response fields?
There was a problem hiding this comment.
The date and year fields aren’t always returned, so they might come back undefined. This way we can make sure nothing explodes and we’re explicitly returning null if these aren’t set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.