Improve metastore observability #4580
Merged
+705
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
commented
Oct 29, 2025
| // | ||
| // The registry is only used on the leader node where Propose() is called. Followers will | ||
| // not have contexts available and will use context.Background() instead. | ||
| type ContextRegistry struct { |
There was a problem hiding this comment.
This will add some memory overhead but I think it is worth it for gaining more visibility. If anyone has alternative ideas, I'd be happy to rework this part.
| } | ||
|
|
||
| ctx := context.Background() | ||
| if ctxID := string(cmd.Extensions); ctxID != "" { |
There was a problem hiding this comment.
We use the extension field of the raft Log type, to carry the context identifiers
|
|
||
| future := n.raft.ApplyLog(raft.Log{ | ||
| Data: raw, | ||
| Extensions: []byte(ctxID), |
There was a problem hiding this comment.
We use the extension field of the raft Log type, to carry the context identifiers (writing point)
aleks-p
force-pushed
the
metastore-tracing-spans
branch
2 times, most recently
from
6fe7d52 to
6429ad7
Compare
aleks-p
force-pushed
the
metastore-tracing-spans
branch
from
6429ad7 to
2fd2481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracing to the metastore public endpoints. This should help troubleshooting cases where the metastore latency goes up. Fixes https://github.com/grafana/pyroscope-squad/issues/603.
Here is an example for the IndexService.AddBlock RPC: