Skip to content

Conversation

@jake-kramer
Copy link
Contributor

Fixes #3989


func (p *PyroscopeTest) TempAppName() string {
return fmt.Sprintf("pprof.integration.%d",
return fmt.Sprintf("pprof-integration-%d",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dots were messing with downstream sample type parsing:

app = pi.LabelSet.ServiceName()
parts := strings.Split(app, ".")
if len(parts) <= 1 {
stType = stTypeCPU
} else {
stType = parts[len(parts)-1]
app = strings.Join(parts[:len(parts)-1], ".")
}

Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jake-kramer jake-kramer enabled auto-merge (squash) October 31, 2025 14:42
@jake-kramer jake-kramer merged commit f2aa2fb into main Oct 31, 2025
21 checks passed
@jake-kramer jake-kramer deleted the speedscope-ingestion-fix branch October 31, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug][pyroscope] Pyroscope does not ingest Speedscope files with multiple profiles

2 participants