Skip to content

chore: Enable helm release workflow and tag v1.31.2 #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented May 6, 2025

This enables the helm release workflow and also update the chart to point to the latest release (v.1.13.2), which we forgot at the time.

@simonswine simonswine requested a review from a team as a code owner May 6, 2025 11:35
@simonswine simonswine changed the title 20250506 helm release workflow chore: Enable helm release workflow and tag v1.31.2 May 6, 2025
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cr_configfile: operations/pyroscope/helm/cr.yaml
ct_configfile: operations/pyroscope/helm/ct.yaml
secrets:
vault_repo_secret_name: grafana-pyroscope-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think we're switching apps here, I am not 100% sure but I think we used to use grafana-pyroscope-releases. I also think it does not matter and probably even better to use less apps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that was intentional, as the vault prefix did not have that other app. Should have mentioned it though. Let's see if it works 🤞

@simonswine simonswine merged commit 03f76ab into main May 7, 2025
24 checks passed
@simonswine simonswine deleted the 20250506_helm-release-workflow branch May 7, 2025 07:59
aleks-p pushed a commit that referenced this pull request May 15, 2025
* chore: Reenable helm-release workflow

* Release v1.13.2 into helm chart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants