feat: Recording rules settings #3946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsoba13
reviewed
Feb 25, 2025
alsoba13
reviewed
Feb 25, 2025
alsoba13
reviewed
Feb 25, 2025
simonswine
reviewed
Feb 25, 2025
|
FYI, I merged main to this branch, so I can make #3945 be a branch of this one and extend it to be consumed by compaction workers (WIP) |
…pe into recording-rules-settings
alsoba13
approved these changes
Feb 26, 2025
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tenant settings submodule that can manage recording rules.
The current API allows for:
/settings.v1.RecordingRulesService/ListRecordingRules/settings.v1.RecordingRulesService/InsertRecordingRule/settings.v1.RecordingRulesService/DeleteRecordingRuleThis is the minimum API required to power the UI. Updates and reading single records are not required by the UI, though I am happy to add them in this PR if we want to attempt a future-proof of this API.
The general architecture of this submodule looks like this: