chore(helm): Remove remnants of built-in Pyroscope agent #3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Pyroscope included an agent, before there was support in Grafana Alloy/Agent for profiling. We forgot to remove RBAC objects in the helm chart. This cleans this up.
|
This is on the back of #3908, thanks @charlesverdad for reporting. |
simonswine
changed the title
marcsanmi
approved these changes
Feb 18, 2025
shelldandy
pushed a commit
to shelldandy/pyroscope
that referenced
this pull request
Mar 14, 2025
Previously Pyroscope included an agent, before there was support in Grafana Alloy/Agent for profiling. We forgot to remove RBAC objects in the helm chart. This cleans this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Pyroscope included an agent, before there was support in Grafana Alloy/Agent for profiling. We forgot to remove RBAC objects in the helm chart. This cleans this up.