fix(v2): use better seed for shard placement #3924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixed a bad seed chosen for Fisher-Yates permutations forming the shard mapping in the new distribution algorithm.
I've noticed that in case of unavailability, the data distribution has pronounces skews and decided to test this case. I discovered that with low number of nodes and shards, the mapping we generate is very poor – the random choice is extremely unfortunate:
After some brute force (for 3-10 instances, where distribution skews are especially impactful) I found a better seed that ensures significantly better behaviour in case of node failures/unavailability:
I'm not adding the scripts I used to find the seed, because I do not plan to maintain it: it's better to replace the randomized permutations with a knapsack solver or something similar that gives deterministic optimal results.