Skip to content

Add profilecli docs #2631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add profilecli docs #2631

merged 1 commit into from
Nov 6, 2023

Conversation

Rperry2174
Copy link
Contributor

adds docs on how to use profilecli

@Rperry2174 Rperry2174 requested review from a team as code owners November 2, 2023 19:08
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


- Here's a basic command template:
```
./profilecli upload --url=<pyroscope_server_url> --username=<username> --password=<password> path/to/your/pprof-file.pprof
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should be adding a service_name label so the app UI can handle it?

Potentially we should maybe also just do that as default in profilecli?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we don't have docs not actually sure where that goes / how to add it can you make a commit here to add it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue for this #2642

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged this so @aleks-p can update docs in his PR where this is added

@Rperry2174 Rperry2174 merged commit 1aec885 into main Nov 6, 2023
@Rperry2174 Rperry2174 deleted the add-profile-cli-docs branch November 6, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants