Skip to content

feat: query store gateway for profile types #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

bryanhuhta
Copy link
Contributor

@bryanhuhta bryanhuhta commented Nov 1, 2023

Related: #2230
Related: https://github.com/grafana/pyroscope-app-plugin/issues/70
Related: grafana/grafana#77523

Previously profile types were only queried from the head block in the ingester. This adds a time window to the ProfileTypes RPC and queries the store gateway if necessary.

Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants