Skip to content

fix: remove request which is handled by fetchAndHandleErrors #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix: remove request which is handled by fetchAndHandleErrors #2613

merged 1 commit into from
Nov 2, 2023

Conversation

darrenjaneczek
Copy link
Collaborator

@darrenjaneczek darrenjaneczek commented Oct 31, 2023 •
edited
Loading

  • Remove old request, which is virtually identical to fetchAndHandleErrors
  • Rename requestWithOrgID to request
  • Make non-imported functions in base not exportable

@darrenjaneczek darrenjaneczek marked this pull request as ready for review October 31, 2023 19:03
@darrenjaneczek darrenjaneczek requested a review from a team as a code owner October 31, 2023 19:03
@darrenjaneczek darrenjaneczek force-pushed the fix/duplicate-code-base-service branch from 4a674f0 to 3960dda Compare November 1, 2023 14:23
@darrenjaneczek darrenjaneczek force-pushed the fix/duplicate-code-base-service branch from 3960dda to 707ef9b Compare November 2, 2023 03:52
@darrenjaneczek
fix: remove request which is handled by fetchAndHandleErrors
352ab25 
fix: rename `requestWithOrgId` to `request`
@darrenjaneczek darrenjaneczek force-pushed the fix/duplicate-code-base-service branch from 707ef9b to 352ab25 Compare November 2, 2023 16:13
@grafakus grafakus self-requested a review November 2, 2023 16:31
@grafakus
Copy link
Collaborator

grafakus commented Nov 2, 2023

Approved after looking at the code. I'm making some tests locally.

@grafakus
Copy link
Collaborator

grafakus commented Nov 2, 2023

Did a swipe over the app and there were no errors.

@darrenjaneczek darrenjaneczek merged commit a4928eb into main Nov 2, 2023
@darrenjaneczek darrenjaneczek deleted the fix/duplicate-code-base-service branch November 2, 2023 17:27
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafakus grafakus grafakus approved these changes

@petethepig petethepig Awaiting requested review from petethepig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenjaneczek @grafakus