Skip to content

fix(SyncBanner): Add 10% buffer on both sides of the timeline #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix(SyncBanner): Add 10% buffer on both sides of the timeline #2608

merged 2 commits into from
Oct 30, 2023

Conversation

grafakus
Copy link
Collaborator

@grafakus grafakus commented Oct 30, 2023 •
edited
Loading

Update on #1615: with a fixed value of 5m the user could end up in a situation where narrow selections wouldn't make the sync banner appear.

This PR:

  • changes from fixed buffers (5m) to a dynamic buffers: we now allow 10% of the timeline duration on both sides of the timeline
  • not related to the issue but... fixes the "Ignore" button that had no effect (the banner wouldn't disappear)

@grafakus grafakus requested a review from a team as a code owner October 30, 2023 15:03
Rperry2174
Rperry2174 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! lgtm

@grafakus grafakus merged commit 58df86d into grafana:main Oct 30, 2023
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rperry2174 Rperry2174 Rperry2174 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grafakus @Rperry2174