Skip to content

Fix "allow https health checks in the Helm chart" #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix "allow https health checks in the Helm chart" #2603

merged 2 commits into from
Oct 30, 2023

Conversation

kolesnikovae
Copy link
Collaborator

@kolesnikovae kolesnikovae commented Oct 30, 2023 •
edited
Loading

Fixes #2601: scheme is case sensitive.

Deployment to the dev cluster has failed:

spec.template.spec.containers[0].readinessProbe.httpGet.scheme: Unsupported value: "http": supported values: "HTTP", "HTTPS"

@kolesnikovae kolesnikovae requested a review from a team as a code owner October 30, 2023 03:36
@kolesnikovae kolesnikovae force-pushed the revert-2601-allow-https-healthchecks-in-helm branch from add87b2 to 9fb7760 Compare October 30, 2023 03:48
@kolesnikovae kolesnikovae changed the title Revert "allow https health checks in the Helm chart" Fix "allow https health checks in the Helm chart" Oct 30, 2023
@kolesnikovae kolesnikovae merged commit f508e6f into main Oct 30, 2023
@kolesnikovae kolesnikovae deleted the revert-2601-allow-https-healthchecks-in-helm branch October 30, 2023 04:14
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korniltsev korniltsev korniltsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolesnikovae @korniltsev