chore(ebpf) python 3.13-rc support #2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Oct 30, 2023
Comment on lines
+74
to
+76
| if classname == "" && filename == "" && name == "" { | ||
| continue | ||
| } |
There was a problem hiding this comment.
I'm curious how often it is happening and whether we should keep track of it, like metric or something
There was a problem hiding this comment.
I saw this happening only for frame->owner == FRAME_OWNED_BY_CSTACK, for example the very first frame started by thread.
The python runtime silently discards them https://github.com/python/cpython/blob/e7331365b488382d906ce6733ab1349ded49c928/Python/traceback.c#L991
I could do same thing in ebpf, but that would require tracking extra structure field offset frame->owner which I am lazy to do.
There was a problem hiding this comment.
I think we can ignore them for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyThreadState.cframewas removed andPyThreadState.current_frameaddedPyInterpreterFrame.f_codewas renamed toPyInterpreterFrame.f_executable