Skip to content

Increase default compaction interval #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

cyriltovena
Copy link
Contributor

I think 1h was too high based on the default block duration 1h too.

Also we can open more block at once without any problem.

@cyriltovena cyriltovena requested a review from a team as a code owner October 24, 2023 16:01
@cyriltovena cyriltovena enabled auto-merge (squash) October 24, 2023 16:01
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What is the cost of compaction interval? Is it mainly listing the bucket and resolving the dependencies?

I probably would even go to 10/15min

@cyriltovena cyriltovena merged commit 9c4d242 into main Oct 24, 2023
@cyriltovena cyriltovena deleted the bugfix/compactor-tweaks-v2 branch October 24, 2023 16:13
cyriltovena added a commit that referenced this pull request Oct 25, 2023
* Rename deploy-monitoring (#2551)

* Tweak compaction configuration and performance. (#2564)

* Tweak compaction configuration and performance.

* Fixes config tests

* review feedback

* Fixes compaction range block grouping (#2570)

* Update `make docs` procedure (#2567)

Co-authored-by: grafanabot <[email protected]>

* docs: improves naming in rideshare example (#2571)

* Revert "fix: remove "Flamegraph" from timeline chart title (#2565)" (#2566)

* Revert "fix: remove "Flamegraph" from timeline chart title (#2565)"

This reverts commit b4e6cef.

* fix: add time range

* Add support for dashboards datasource filter (#2560)

This commit add support for dashboards datasource filter using a regex named 'datasource_regex'
provided in the config.libsonnet file.

It's done in a similar way than for grafana/mimir.

Signed-off-by: julien.girard <[email protected]>

* Increase default compaction interval (#2575)

* feat(ebpf): add pyperf (#2201)

* Document the new configuration flag PYROSCOPE_AGENT_ENABLED (#2536)

* Ignore block within 3h in the store-gateway (#2579)

* chore(ebpf)  py312 support (#2577)

* add py312 testdata

* chore(ebpf): py 3.12 support

* unhardcode more offsets

* ingest: drop empty pprof profiles (#2580)

* ingest: drop empty pprof profiles

* add testcase

* Make sure loki extracts the right labels (#2582)

* docs: fix the "Type mismatch" error in "Rust client configuration" (#2581)

---------

Signed-off-by: julien.girard <[email protected]>
Co-authored-by: Christian Simon <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: grafanabot <[email protected]>
Co-authored-by: Dmitry Filimonov <[email protected]>
Co-authored-by: Darren Janeczek <[email protected]>
Co-authored-by: Julien Girard <[email protected]>
Co-authored-by: Tolya Korniltsev <[email protected]>
Co-authored-by: Franz Wimmer <[email protected]>
Co-authored-by: Daxin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants