Skip to content

ci: fixes homebrew formulas generation #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2023
Merged

ci: fixes homebrew formulas generation #2527

merged 2 commits into from
Oct 12, 2023

Conversation

petethepig
Copy link
Collaborator

@petethepig petethepig commented Oct 12, 2023 •
edited
Loading

Fixes a few issues:

  • introduces two tokens, one for homebrew repo, one for pyroscope proper
  • clones homebrew-brew to an adjacent directory, so that it's not in the same go workspace as pyroscope
  • adds email / name for the commit

This PR consists of cherry picked commits from https://github.com/grafana/pyroscope/tree/release/v1.1

@petethepig petethepig requested a review from a team as a code owner October 12, 2023 16:21
simonswine
simonswine approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig enabled auto-merge (squash) October 12, 2023 16:24
@petethepig petethepig disabled auto-merge October 12, 2023 16:24
@petethepig petethepig enabled auto-merge (squash) October 12, 2023 16:24
@petethepig petethepig merged commit f402d83 into main Oct 12, 2023
@petethepig petethepig deleted the brew-fixes branch October 12, 2023 16:30
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petethepig @simonswine