Feat: ingest align block ranges. #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bryanhuhta check out the small refactoring it should make your life easier. |
Co-authored-by: Anton Kolesnikov <[email protected]>
…lock' into feat/ingest-align-block
simonswine
approved these changes
Oct 12, 2023
bryanhuhta
approved these changes
Oct 12, 2023
| @@ -268,7 +267,7 @@ func (i *Ingester) Flush(ctx context.Context, req *connect.Request[ingesterv1.Fl | |||
| i.instancesMtx.RLock() | |||
| defer i.instancesMtx.RUnlock() | |||
| for _, inst := range i.instances { | |||
| if err := inst.Flush(ctx); err != nil { | |||
| if err := inst.Flush(ctx, true, "api"); err != nil { | |||
There was a problem hiding this comment.
Should "api" be a constant somewhere? Just like flushReasonMaxBlockBytes and flushReasonMaxDuration.
There was a problem hiding this comment.
may be ? It doesn't add much if it used once, but +1 on consistency.
Comment on lines
+394
to
+395
| if req.Msg.Start == 0 || req.Msg.End == 0 { | ||
| return f.headQueriers().Series(ctx, req) |
| @@ -405,6 +423,19 @@ func InRange(q Querier, start, end model.Time) bool { | |||
| return true | |||
| } | |||
|
|
|||
| type ReadAPI interface { | |||
There was a problem hiding this comment.
This type is here strictly to enforce Queriers implements these methods, correct? I don't see it used anywhere else.
There was a problem hiding this comment.
Yeah we don't really need it, but I think this is the start of a bigger refactoring, we in fact should only implement this in Queriers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns block ranges when flushing heads.
To do this and still support out of order, we actually maintain multiple head and flush them after a certain period once they go stale.
Still needs to add some tests but it basically work nicely here is a screenshot showing 1m and 30m block perfectly aligned now
Todos