feat: get label names from store gateway #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanhuhta
commented
Oct 6, 2023
bryanhuhta
commented
Oct 6, 2023
kolesnikovae
reviewed
Oct 9, 2023
cyriltovena
reviewed
Oct 9, 2023
bryanhuhta
commented
Oct 11, 2023
pkg/util/time.go
Outdated
Comment on lines
102
to
110
| type TimeRangeRequest interface { | ||
| GetStart() int64 | ||
| GetEnd() int64 | ||
| } | ||
|
|
||
| // HasTimeRange is true if the request has a start and end set. | ||
| func HasTimeRange(req TimeRangeRequest) bool { | ||
| return req.GetStart() == 0 || req.GetEnd() == 0 | ||
| } |
There was a problem hiding this comment.
I had to move this helper here, instead of adding a method directly on typesv1.LabelNamesRequest. If I tried to add it directly on the type, the definition got deleted every time we regenerated the protobuf code.
There was a problem hiding this comment.
Yep that make sense, may be model makes also sense up to you.
cyriltovena
reviewed
Oct 13, 2023
cyriltovena
reviewed
Oct 13, 2023
cyriltovena
approved these changes
Oct 13, 2023
|
I put 38f39cb in dev and ran some quick tests and I couldn't find any appreciable difference for querying label names for the store gateway regardless of the time window. For a 2d to 14d windows it takes about 100ms from my browser and about 1 - 10ms server side. I'll merge this in and let it cook. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2230
Related: https://github.com/grafana/pyroscope-app-plugin/issues/70
Previously label names were only queried from the head block in the ingester. This adds a time window to the LabelNames RPC and queries the store gateway if necessary.