[packaging] Create pyroscope unix group #2485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Oct 5, 2023
tools/packaging/postinstall.sh
Outdated
| # Create the user | ||
| if ! id pyroscope > /dev/null 2>&1 ; then | ||
| adduser --system --home /var/lib/pyroscope --shell /bin/false "pyroscope" | ||
| adduser --create-home --system --home /var/lib/pyroscope -g pyroscope --shell /bin/false "pyroscope" |
There was a problem hiding this comment.
I think debian doesn't like create-home and only shares --gid with the redhat variant:
Suggested change
| adduser --create-home --system --home /var/lib/pyroscope -g pyroscope --shell /bin/false "pyroscope" | |
| adduser --system --home /var/lib/pyroscope --gid $(getent group | grep pyroscope: | awk -F ":" '{ print $3 }') --shell /bin/false "pyroscope" |
There was a problem hiding this comment.
I've made a little improvement to your suggestion.
WDYT?
wilfriedroset
force-pushed
the
packaging-system-group
branch
from
70f9ab9 to
0abdc18
Compare
Signed-off-by: Wilfried Roset <[email protected]>
wilfriedroset
force-pushed
the
packaging-system-group
branch
from
0abdc18 to
57dd6a1
Compare
simonswine
pushed a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: Wilfried Roset <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR create a unix group for pyroscope user. This will facilitate permission management down the road.
Bonus point: it is similar to mimir packaging. This could be an improvement for loki