Skip to content

feat: get series labels from store gateway #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Sep 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
5e3db53
Fix generate rule when there are spaces in PATH
bryanhuhta Sep 19, 2023
18e457b
Add start/end to series requests
bryanhuhta Sep 19, 2023
735aaac
Add Series method to store gateway
bryanhuhta Sep 19, 2023
f9f8417
Initial framework for querying store gateway
bryanhuhta Sep 19, 2023
1960565
Create framework for querying store gateway
bryanhuhta Sep 19, 2023
e497415
Implement store gateway query from querier
bryanhuhta Sep 19, 2023
1a8c263
More frameworking for querying block storage
bryanhuhta Sep 19, 2023
9361cf8
Sketch out series query for block
bryanhuhta Sep 19, 2023
7c84de7
Stub out store gateway series queries
bryanhuhta Sep 19, 2023
8dafcaa
Implement series query for head queriers
bryanhuhta Sep 19, 2023
1e8fd94
Query single block
bryanhuhta Sep 20, 2023
4d209d8
Add start/end
bryanhuhta Sep 20, 2023
79198d8
Filter labels by labelname set
bryanhuhta Sep 20, 2023
520238d
Remove unused func
bryanhuhta Sep 20, 2023
07804ca
Implement matchers
bryanhuhta Sep 20, 2023
7135bce
Merge branch 'main' into sg-labels
bryanhuhta Sep 20, 2023
0f81a68
Send start/end from frontend
bryanhuhta Sep 20, 2023
58ad978
yarn format:fix
bryanhuhta Sep 20, 2023
f4eec65
Account for legacy requests that have no start/end
bryanhuhta Sep 21, 2023
d8df865
Move validation to frontend and add more complete validation
bryanhuhta Sep 21, 2023
d671a6a
Don't try query series labels with headOnDiskQuerier
bryanhuhta Sep 21, 2023
a9182ac
Actually query on-disk blocks
bryanhuhta Sep 21, 2023
cc05423
Add comment about query resolution
bryanhuhta Sep 21, 2023
e0c8640
Update documentation
bryanhuhta Sep 21, 2023
cfff10f
Fix some todos
bryanhuhta Sep 21, 2023
c72f5c6
Revert UI changes
bryanhuhta Sep 21, 2023
00bda46
Merge branch 'main' into sg-labels
bryanhuhta Sep 21, 2023
005dfc8
Fix lint
bryanhuhta Sep 21, 2023
06f690b
Fix lint
bryanhuhta Sep 21, 2023
7bd3a1d
yarn lint:fix
bryanhuhta Sep 21, 2023
9955faf
Please please please format
bryanhuhta Sep 21, 2023
481345c
Add some basic tests
bryanhuhta Sep 22, 2023
0bdb433
Use the postings API to get and filter series and add some more tests
bryanhuhta Sep 25, 2023
97b4dbf
Merge branch 'main' into sg-labels
bryanhuhta Sep 25, 2023
aaf8f9e
Fix timestamps in validation
bryanhuhta Sep 26, 2023
0d587b3
Add legacy request check to ingester
bryanhuhta Sep 26, 2023
b740e24
Fix timestamps
bryanhuhta Sep 26, 2023
6a54fae
Add some span logging
bryanhuhta Sep 26, 2023
cdf6a88
Remove scratch file
bryanhuhta Sep 26, 2023
3d9b990
Remove scratch file
bryanhuhta Sep 26, 2023
e38c538
Add store query logging
bryanhuhta Sep 26, 2023
1d1eefd
Use `TimeFromUnix`
bryanhuhta Sep 26, 2023
3b4b620
Skip validation if no start/end were provided
bryanhuhta Sep 26, 2023
4c83f36
Add default interval to request in query frontend
bryanhuhta Sep 26, 2023
dcb5d36
Parallelize ingester/store gateway requests
bryanhuhta Sep 26, 2023
56a5afc
Merge branch 'sg-labels' of github.com:grafana/pyroscope into sg-labels
bryanhuhta Sep 26, 2023
bb1fb50
Merge branch 'main' into sg-labels
bryanhuhta Sep 26, 2023
02ec939
Hmm try wait for the errgroup to finish
bryanhuhta Sep 26, 2023
8256b3f
Rename test
bryanhuhta Sep 27, 2023
29cb7bb
Don't alloc slices every iteration
bryanhuhta Sep 27, 2023
416b25c
Add basic benchmark
bryanhuhta Sep 27, 2023
25c8008
Refactor `singleBlockQuerier.Series`
bryanhuhta Sep 27, 2023
25c3f0f
Ignore lints
bryanhuhta Sep 27, 2023
28d98bb
Set limit for concurrent block queries
bryanhuhta Sep 27, 2023
a9dc85e
Deduplicate labels in store gateway
bryanhuhta Sep 28, 2023
bd1c70d
Match everything if no labels are provided
bryanhuhta Sep 28, 2023
59f4ed2
Sort label sets
bryanhuhta Sep 28, 2023
f508ad3
Only validate if start/end interval is provided
bryanhuhta Sep 28, 2023
1830d74
Merge branch 'main' into sg-labels
bryanhuhta Sep 28, 2023
47fca70
Use unix ms instead of unix s
bryanhuhta Sep 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ generate: $(BIN)/buf $(BIN)/protoc-gen-go $(BIN)/protoc-gen-go-vtproto $(BIN)/pr
find pkg/ \( -name \*.pb.go -o -name \*.connect\*.go \) -delete
cd api/ && PATH=$(BIN) $(BIN)/buf generate
cd pkg && PATH=$(BIN) $(BIN)/buf generate
PATH=$(BIN):$(PATH) ./tools/add-parquet-tags.sh
PATH="$(BIN):$(PATH)" ./tools/add-parquet-tags.sh
go run ./tools/doc-generator/ ./docs/sources/configure-server/reference-configuration-parameters/index.template > docs/sources/configure-server/reference-configuration-parameters/index.md

.PHONY: buf/lint
Expand Down
377 changes: 198 additions & 179 deletions api/gen/proto/go/ingester/v1/ingester.pb.go

Large diffs are not rendered by default.

59 changes: 58 additions & 1 deletion api/gen/proto/go/ingester/v1/ingester_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

294 changes: 156 additions & 138 deletions api/gen/proto/go/querier/v1/querier.pb.go

Large diffs are not rendered by default.

59 changes: 58 additions & 1 deletion api/gen/proto/go/querier/v1/querier_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

56 changes: 32 additions & 24 deletions api/gen/proto/go/storegateway/v1/storegateway.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 38 additions & 1 deletion api/gen/proto/go/storegateway/v1/storegateway_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading