Skip to content

feat: add params for initContainers, and hostNetwork #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2023
Merged

feat: add params for initContainers, and hostNetwork #2363

merged 2 commits into from
Sep 7, 2023

Conversation

bodji
Copy link
Contributor

@bodji bodji commented Sep 5, 2023

No description provided.

@bodji bodji requested a review from a team as a code owner September 5, 2023 12:32
@CLAassistant
Copy link

CLAassistant commented Sep 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kolesnikovae
kolesnikovae reviewed Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🎉

The change looks good. I've left a couple of comments. Also, may I ask you to sign the CLA please?

@bodji
Copy link
Contributor Author

bodji commented Sep 6, 2023

I signed the CLA.

I removed serviceAnnotations (already brought by: #2364)

I removed the v1beta for pod disruption budget

@bodji bodji changed the title feat: add params for serviceAnnotations, initContainers, and hostNetwork feat: add params for initContainers, and hostNetwork Sep 6, 2023
kolesnikovae
kolesnikovae reviewed Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please run make helm/check and make helm/docs to update rendered manifests and the documentation?

@bodji bodji force-pushed the main branch 2 times, most recently from f7cabdd to c1a6a61 Compare September 6, 2023 12:49
@bodji
Copy link
Contributor Author

bodji commented Sep 6, 2023

Done :)

kolesnikovae
kolesnikovae reviewed Sep 7, 2023
View reviewed changes
@bodji bodji force-pushed the main branch 2 times, most recently from 94cb75c to 8b7bc95 Compare September 7, 2023 07:59
@bodji
Copy link
Contributor Author

bodji commented Sep 7, 2023

I added a "-n default" to the helm/check helm commands in the makefile.

Because by default, it takes the current namespace set in the kube context

What do you think ?

@cyriltovena
Copy link
Contributor

I added a "-n default" to the helm/check helm commands in the makefile.

Because by default, it takes the current namespace set in the kube context

What do you think ?

perfect !

cyriltovena
cyriltovena approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 55176d0 into grafana:main Sep 7, 2023
This was referenced Sep 8, 2023
Merged
Merged
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolesnikovae kolesnikovae kolesnikovae left review comments

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bodji @CLAassistant @cyriltovena @kolesnikovae