Skip to content

docs: updates examples with grafana/pyroscope, enforces consistent style #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Aug 25, 2023

Conversation

petethepig
Copy link
Collaborator

@petethepig petethepig commented Aug 25, 2023

See commit log for list of changes.

  • For most examples I changed pyroscope/pyroscope to grafana/pyroscope
  • For some I had to add Grafana Agent
  • Some I deleted

@petethepig petethepig changed the title wip: pre-v1 examples updates docs: updates examples with grafana/pyroscope, enforces consistent style Aug 25, 2023
@petethepig petethepig marked this pull request as ready for review August 25, 2023 19:55
@petethepig petethepig requested a review from a team as a code owner August 25, 2023 19:55
Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions, but otherwise LGTM

command:
- run
- /etc/agent-config/config.river
- --server.http.listen-addr=0.0.0.0:12345
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is port 12345 correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Comment on lines +1 to +2
production:
secret_key_base: placeholder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually needed for the example Rails app?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants