Skip to content

fix(docs): fix dotnet missing links, remove auth token from docs #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 28, 2023
Merged

fix(docs): fix dotnet missing links, remove auth token from docs #2310

merged 7 commits into from
Aug 28, 2023

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented Aug 25, 2023 •
edited
Loading

  • update docs on obtaining dotnet libraries
  • remove auth token mentions from variaous places
  • make tenant_id optinoal, comment it
  • reformat rust docs

@korniltsev korniltsev requested review from a team as code owners August 25, 2023 10:30
@korniltsev korniltsev changed the title fix(docs): dotnet obtaining shared libraries fix(docs): fix dotnet missing links, remove auth token from docs Aug 25, 2023
simonswine
simonswine approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bryanhuhta
bryanhuhta approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor nits, but looks good 👍

@Rperry2174 Rperry2174 enabled auto-merge (squash) August 28, 2023 17:31
@Rperry2174 Rperry2174 merged commit 769772a into next Aug 28, 2023
@Rperry2174 Rperry2174 deleted the update_dotnet_docs branch August 28, 2023 17:31
@jdbaldry jdbaldry mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

@bryanhuhta bryanhuhta bryanhuhta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@korniltsev @simonswine @bryanhuhta @Rperry2174