Skip to content

chore: renames phlaredb to pyroscopedb #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

petethepig
Copy link
Collaborator

@petethepig petethepig commented Aug 16, 2023

@simonswine
Copy link
Contributor

This is should be fine to change https://github.com/pyroscope-io/pyroscope/blob/5dbd4fb1fe294f57651fa70405acf5a666b13d2e/pkg/phlaredb/profile_store.go#L68

@simonswine
Copy link
Contributor

Probably while you in the file:

parquet.CreatedBy("github.com/grafana/phlare/", build.Version, build.Revision),

Co-authored-by: Christian Simon <[email protected]>
@petethepig petethepig force-pushed the phlaredb-pyroscopedb branch from 8c9bc0b to e44338b Compare August 16, 2023 14:59
@petethepig petethepig marked this pull request as ready for review August 16, 2023 21:35
@petethepig petethepig requested review from a team as code owners August 16, 2023 21:35
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petethepig petethepig merged commit 795b2ef into next Aug 17, 2023
@petethepig petethepig deleted the phlaredb-pyroscopedb branch August 17, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants