fix(ebpf): make kallsyms lazy #2245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
approved these changes
Aug 14, 2023
| sc.kallsyms, err = NewKallsyms() | ||
| if err != nil { | ||
| level.Error(sc.logger).Log("msg", "kallsyms init fail", "err", err) | ||
| sc.kallsyms = NewSymbolTab(nil) |
There was a problem hiding this comment.
Nit: Unsure if you want to return here right away, as I guess the errors are not necessarily related?
Suggested change
| sc.kallsyms = NewSymbolTab(nil) | |
| sc.kallsyms = NewSymbolTab(nil) | |
| return |
There was a problem hiding this comment.
I did not return on purpose to emit second error message with hints how to try to bypass permission errors
|
Sorry I wanted to click "resolve conversation" instead of "rebase and merge" |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will save couple of megabytes when
CollectKernel=false( /proc/kallsyms is 2M on our dev nodes and 16M on my machine)