Skip to content

fix(docs): remove 'native' from python docs #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix(docs): remove 'native' from python docs #2244

merged 2 commits into from
Aug 14, 2023

Conversation

korniltsev
Copy link
Collaborator

No description provided.

@korniltsev korniltsev requested review from a team as code owners August 14, 2023 04:46
@@ -42,7 +42,6 @@ pyroscope.configure(
sample_rate = 100, # default is 100
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rperry2174 should we remove auth_token from this example to not confuse users?
auth_token is only needed for og pyroscope, seems like we should not advertise it.

@korniltsev korniltsev requested a review from Rperry2174 August 14, 2023 04:47
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm yeah let's remove auth token too if that's the one for og pyroscope can we replace it with new authentication?

@korniltsev korniltsev enabled auto-merge (squash) August 14, 2023 14:23
@korniltsev korniltsev merged commit 584435c into next Aug 14, 2023
@korniltsev korniltsev deleted the docs/py_native branch August 14, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants