Skip to content

Fix broken tests on MacOS #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fix broken tests on MacOS #2242

merged 2 commits into from
Aug 11, 2023

Conversation

0xPoe
Copy link
Contributor

@0xPoe 0xPoe commented Aug 11, 2023

When I run make test on my MacOS. I got some errors:

ebpf/rlimit/internal/internal_mirror.go:13:20: undefined: unix.BPF_OBJ_NAME_LEN
ebpf/rlimit/internal/internal_mirror.go:39:36: undefined: unix.SYS_BPF
ebpf/cmd/playground/main.go:27:26: undefined: ebpfspy.NewSession
ebpf/cmd/playground/main.go:48:38: undefined: ebpfspy.SessionOptions
ebpf/cmd/playground/main.go:50:17: undefined: ebpfspy.SessionOptions
ebpf/cmd/playground/main.go:54:24: undefined: symtab.CacheOptions

This PR try add the right build tag to skip it on MacOS.

Signed-off-by: hi-rustin <[email protected]>
@0xPoe 0xPoe requested a review from korniltsev as a code owner August 11, 2023 12:34
@CLAassistant
Copy link

CLAassistant commented Aug 11, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Signed-off-by: hi-rustin <[email protected]>
@korniltsev korniltsev merged commit e8a44ef into grafana:next Aug 11, 2023
@0xPoe 0xPoe deleted the rustin-patch-tests branch August 11, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants