feat: add ReasonFailed #18055
Merged
feat: add ReasonFailed #18055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new reason called ReasonFailed. It is used in proto.ExceedsLimitsResult when a stream cannot be checked against a tenant's limits due to an error. It allows this information to be fed back to the distributors which can then make a decision whether to accept or reject the streams (for example, having a per-tenant toggle).
This was referenced Jun 17, 2025
periklis
approved these changes
Jun 17, 2025
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds a new reason called
ReasonFailed. It is used inproto.ExceedsLimitsResultwhen a stream cannot be checked against a tenant's limits due to an error. It allows this information to be fed back to the distributors which can then make a decision whether to accept or reject the streams (for example, having a per-tenant toggle).This reason is not used in this pull request, that will be done in a follow up PR.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR