-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(helm): Add validation for loki.storage.bucketNames #13781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jayclifford345
merged 31 commits into
grafana:main
from
horihel:horihel-work-around-helm-lint-bug
Jul 29, 2025
Merged
Changes from 26 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
913401c
Update _helpers.tpl
horihel 466009a
Update Chart.yaml
horihel 3079030
Update CHANGELOG.md
horihel 06730bd
Update README.md
horihel 4e53946
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel f64f46f
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel 70ee6a0
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel b00e48b
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel 4681c9a
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel 7586e36
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel f7c7b2d
Update _helpers.tpl
horihel da8aeaa
Apply suggestions from code review
horihel 29002d9
remove version bumps
horihel 5caaaea
move validation of bucketNames into validate.yaml
horihel 9a980cb
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel 4e56083
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel bfdcd85
check for adminApi before validating "admin" bucketName
horihel 85788fe
Update production/helm/loki/templates/validate.yaml
horihel 9c42ca5
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel 66628a3
Revert bucketname change in _helpers.tpl, change to validation-only
horihel 3661aa0
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel a24722a
Merge branch 'main' into horihel-work-around-helm-lint-bug
horihel 29cfa33
revert de-dupe/sort
horihel 303b041
Merge branch 'main' into horihel-work-around-helm-lint-bug
JStickler 25184fd
Update production/helm/loki/templates/validate.yaml
horihel f16fc15
Merge branch 'main' into horihel-work-around-helm-lint-bug
JStickler f8825db
Update production/helm/loki/templates/validate.yaml
horihel 72e8687
Merge branch 'main' into horihel-work-around-helm-lint-bug
Jayclifford345 0bcc2fc
Merge branch 'main' into horihel-work-around-helm-lint-bug
Jayclifford345 f685e16
Merge branch 'main' into horihel-work-around-helm-lint-bug
Jayclifford345 3192b38
Merge branch 'main' into horihel-work-around-helm-lint-bug
Jayclifford345 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.