Skip to content

Conversation

@erickuiper
Copy link
Contributor

@erickuiper erickuiper commented Jun 27, 2025

image

We deploy this chart using ArgoCD and the application remains out-of-sync due to a missing default value.

This PR aligns with the httproute spec

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2025

CLA assistant check
All committers have signed the CLA.

@erickuiper erickuiper force-pushed the main branch 2 times, most recently from d3e19ca to 22030ef Compare June 27, 2025 09:04
Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erickuiper Thanks for the contribution, I believe this is the supporting gateway-api docs for the proposed change, if otherwise feel free to add supporting references in the PR description.

Copy link
Collaborator

@Sheikh-Abubaker Sheikh-Abubaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTm

@jkroepke jkroepke merged commit 0fae436 into grafana:main Jun 27, 2025
11 checks passed
tcp13equals2 pushed a commit that referenced this pull request Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants