[simple.App] Allow Config to Supply a ClientGenerator #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han always generating one with the default client config.
radiohead
approved these changes
Oct 17, 2025
radiohead
requested changes
Oct 17, 2025
Contributor
radiohead
left a comment
radiohead
left a comment
There was a problem hiding this comment.
Meant to request changes.
Co-authored-by: Igor Suleymanov <[email protected]>
radiohead
approved these changes
Oct 17, 2025
Contributor
radiohead
left a comment
radiohead
left a comment
There was a problem hiding this comment.
Meant to request changes.
ferruvich
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing a client generator in the config, rather than always generating one with the default client config. If one is not provided in the config, the default is the prior logic.